Python: Improvements for MCP#14003
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Collaborator
Author
Python Test Coverage Report •
Python Unit Test Overview
|
||||||||||||||||||||||||||||||
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances the Python MCP connector to (1) optionally gate MCP “sampling” requests behind a user-provided async consent callback and (2) avoid tool/prompt name collisions with existing plugin attributes, with accompanying unit tests.
Changes:
- Add
sampling_consent_callback(async) to MCP plugin constructors and enforce it insampling_callback(). - Add name-conflict detection to prevent MCP tool/prompt names from overwriting existing plugin attributes.
- Add unit tests covering sampling consent denial, default auto-approval warning logging, and reserved-name collision behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| python/semantic_kernel/connectors/mcp.py | Introduces optional sampling consent callback + warning behavior; adds conflict checks when materializing MCP tools/prompts. |
| python/tests/unit/connectors/mcp/test_mcp.py | Adds tests for consent denial, warning logging when no callback is configured, and prevention of attribute shadowing. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
SergeyMenshykh
approved these changes
May 13, 2026
alliscode
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Improvements for MCP tool calls by adding an optional sampling callback.
Description
Improvements for MCP tool calls by adding an optional sampling callback.
Contribution Checklist